-
Notifications
You must be signed in to change notification settings - Fork 153
docs(maintenance): create upgrade guide from v1 to v2 #1994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
226a14c
to
8ab8730
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first quick pass. Will continue editing on ESM section after lunch.
Added explanations to editing so you can learn about the process too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continuing the review in 2m ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more early editing feedback with some tips on how you can lead with the answer, explain reusable concepts upfront, and shorten / merge paragraphs for a quicker understanding.
[more soon]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log sampling reviewed.
A quick tip is to use a table for enumerating more than one behavior change. A table helps the eye to quickly glance at each key change, along with a before/after without a code snippet per se.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final review before our writing tips session tomorrow to walk through the written feedback here.
I'll leave the last section so you can apply before/after and tips I shared earlier.
Sharing my mental model after our live session going through these PR comments with the reasoning why. flowchart LR
Verbose[Start verbose] --> Cut[Keep the meaning, not the length] --> Cues[Use formats and visual to your advantage] --> Tenets[Remember our progressive tenet and our global audience]
Last but not least, rely on these for judgement when to accept suggestions or continue editing it:
Hope that helps <3 |
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
|
Reviewing the last changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shiiiiip it! This is super exciting -- Thank you @dreamorosi and @am29d for the incredibly hard work you put into this!
Description of your changes
This PR introduces a new version of the upgrade guide that now contains all the details for migrating from v1 to v2.
While the page is expected to be exhaustive at launch, we expect and are committed to treat it as a living document and complement it with additional sections/details as needed based on customer feedback post release.
Related issues, RFCs
Issue number: #1983
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.